Re: [stable] [PATCH] INPUT: Sanitize PIT locking in pcspkr

From: Chris Wright
Date: Mon Jun 11 2007 - 20:29:25 EST


* Thomas Gleixner (tglx@xxxxxxxxxxxxx) wrote:
> The PC-speaker code has a quite creative method to serialize access to
> the PIT: It uses a local lock.
>
> On i386 and x86_64 the access to the PIT is serialized by a lock in the
> architecture code. The separate locking in the PC-speaker code ignores
> the global lock and creates a nasty race between the PC-speaker and the
> PIT clock source / events code on SMP machines.
>
> Use the global i8253_lock instead of the local i8253_beep_lock, when
> compiled for i386/x86_64.

Seems this one got lost?

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/