Re: [Intel-IOMMU 02/10] Library routine for pre-allocat pool handling

From: Christoph Lameter
Date: Mon Jun 11 2007 - 19:29:13 EST

On Tue, 12 Jun 2007, Andi Kleen wrote:

> > If the only option is to panic then something's busted. If it's network IO
> > then there should be a way of dropping the frame. If it's disk IO then we
> > should report the failure and cause an IO error.
> An block IO error is basically catastrophic for the system too. There isn't really
> a concept of "temporary IO error that will resolve itself" concept in Unix.

In Unix? You mean the block layer cannot handle a I/O error? Not too
familiar with it but from what I can tell an I/O operation can be aborted
in the request function.

> There are still lots of users of pci_map_single() that don't check the return
> value unfortunately. That is mostly in old drivers; it is generally
> picked on in reviews now. But then there is no guarantee that these rarely
> used likely untested error handling paths actually work.

Then we need to review the code and clean these up.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at