Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

From: Eduard-Gabriel Munteanu
Date: Mon Jun 11 2007 - 05:58:00 EST


*This message was transferred with a trial version of CommuniGate(r) Pro*
Tejun Heo wrote:

This patchset contains three minimal backports of fixes in -mm. With
all patches in the patchset and sysfs-races.patch applied, kernel
survived ~20 hours of stress test without any problem.


Seriously, do you think adding a few sleeps fixes anything? It just makes it harder to happen, and even harder to debug, so this is no good. Race condition are fixed by proper locking, ordering and so on.

(No offence, this has to be the patch of the week. :) )
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/