Re: [patch-mm 01/23] NOHZ: Fix ARM,SH,SPARC64 idle nohz handling

From: Paul Mundt
Date: Mon Jun 11 2007 - 01:33:45 EST


On Mon, Jun 11, 2007 at 07:20:59AM +0200, Thomas Gleixner wrote:
> On Mon, 2007-06-11 at 09:26 +0900, Paul Mundt wrote:
> >
> > There are two paths here depending on hlt/nohlt setting, we need to have
> > tick_nohz_stop_sched_tick() for the TIF_POLLING_NRFLAG case, too.
>
> Do you really want to run through that in every loop iteration ? If you
> have nohlt, then nohz is rather pointless.
>
Well, nohlt is a corner case, but even so, nohz doesn't really make much
sense in the polling case. tick_nohz_restart_sched_tick() is also safe in
either path, so let's just go with your original patch. Sorry for the noise.

Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/