Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof

[Jan-Benedict Glaw]

On Sun, 2007-06-10 15:11:22 +0200, Karsten Keil <kkeil@xxxxxxx> wrote:
> > --- a/drivers/isdn/hisax/callc.c
> > +++ b/drivers/isdn/hisax/callc.c
> > @@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata =
> >  };
> >  /* *INDENT-ON* */
> >  
> > -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
> > +#define FNCOUNT ARRAY_SIZE(fnlist)
> >  
> >  int __init
> >  CallcNew(void)
>
> This is OK, thanks for changing.

I'd suggest to not use another define, but use ARRAY_SIZE(foo)
_instead of_ eg. FNCOUNT.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@xxxxxxxxxx              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein biÃchen viel Realitycheck.
the second  :               Langsam mÃchte ich mal wieder weitertrÃumen kÃnnen.
                             -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)

Attachment: signature.asc
Description: Digital signature