Re: [patch-mm 06/23] clockevents: Fix resume logic

From: Rafael J. Wysocki
Date: Sun Jun 10 2007 - 07:23:36 EST


On Sunday, 10 June 2007 12:30, Thomas Gleixner wrote:
> On Sun, 2007-06-10 at 12:19 +0200, Rafael J. Wysocki wrote:
> > > -/*
> > > - * Suspend/resume part
> > > - */
> > > -
> > > -#ifdef CONFIG_PM
> > > -
> > > -static int hpet_suspend(struct sys_device *sys_device, pm_message_t state)
> > > -{
> > > - unsigned long cfg = hpet_readl(HPET_CFG);
> > > -
> > > - cfg &= ~(HPET_CFG_ENABLE|HPET_CFG_LEGACY);
> > > - hpet_writel(cfg, HPET_CFG);
> > > -
> > > - return 0;
> > > -}
> >
> > Hmm, I haven't found anything to replace the above in the patch. Is that
> > intentional, or is it there, but I haven't noticed?
>
> > > + case CLOCK_EVT_MODE_RESUME:
> > > + hpet_enable_int();
> > > + break;

This is the resume part, or at least it seems so, but the above one is a
suspend callback. If I understand it correctly, this one replaces
hpet_resume(), but is it sufficient for the suspend part too?

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/