Re: [PATCH] [2.6.22] libata: fix probe time irq printouts

[Jeff Garzik]

Olof Johansson wrote:
> Most drivers don't seem to fill out the host->irq field, resulting in the
> wrong (no) irq being reported at probe time. For example, sil24 on my system:
>
> ata1: SATA max UDMA/100 cmd 0xd00008009001f000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
> ata2: SATA max UDMA/100 cmd 0xd000080090021000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
>
> Since they're allocated and set up in ata_host_activate(), just save
> them away there.
>
>
> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
>
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index af62514..7491b11 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6438,6 +6438,9 @@ int ata_host_activate(struct ata_host *host, int irq,
>  	if (rc)
>  		devm_free_irq(host->dev, irq, host);
>  
> +	/* Used to print device info at probe */
> +	host->irq = irq;
> +

applied, thanks for fixing that


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/