Re: [PATCH 0/7] Cleanup code to replace DPRINTK with pr_debug

From: Ian Kent
Date: Sat Jun 09 2007 - 03:00:24 EST


On Fri, 2007-06-08 at 23:18 +0100, Jack Stone wrote:
> This patch series replaces DPRINTK with pr_debug in alternative.c,
> autofs, autofs4
> and ncpfs. A new function called pr_err is also added to keep
> functionality in
> ncpfs. The last 2 patches add support for pr_debug_pid and apply it to
> autofs4 to
> keep the output the same as the current DPRINTK statements.

And ???

Presenting patches without the reason why they are needed is not a good
policy.

Not to mention that several appear to be missing headers, I can't
believe you tested that they applied before posting them.

NACK.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/