Re: networking busted in current -git ???

From: Herbert Xu
Date: Fri Jun 08 2007 - 21:17:33 EST

Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:
> It appears to be something in the latest dump from davem to Linus, but I
> haven't yet had time to identify what.

You want this patch which should hit the tree soon.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
[IPV4]: Do not remove idev when addresses are cleared

Now that we create idev before addresses are added, it no longer makes
sense to remove them when addresses are all deleted.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 354e800..0cf813f 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -327,12 +327,8 @@ static void __inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,

- if (destroy) {
+ if (destroy)
- if (!in_dev->ifa_list)
- inetdev_destroy(in_dev);
- }

static void inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at