[PATCH 0/2] i386: Fix two more NMI watchdog bugs

From: Björn Steinbrink
Date: Fri Jun 08 2007 - 14:44:50 EST


Hi Ingo,

On 2007.06.08 12:58:08 +0200, Ingo Molnar wrote:
>
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > Half of this (the first hunk) has been in Andi's tree for a day or
> > two.
> >
> > I shall drop Andi's patch, queue this one up and shall send this off
> > to Linus if nothing else happens in the next couple of days.
>
> this patch does not fix the NMI watchdog bootup lockup i can reproduce,
> it still occurs in -rc4 too. Andi, could you please react to my report?
> See the "2.6.22-rc3 nmi watchdog hang" thread on lkml.

Ok, so after I figured out again how to enable the nmi watchdog, I found
a few more bugs. One is pretty clear, calling a function directly while
the wrapper should be used, causing a(nother) BUG() when the watchdog is
disabled using /proc/sys/...

The other is less clear (to me). It seems like the perfect candidate to
muck up the watchdog, but I can't get it to do that. On system boot up,
the MSRs are no longer reserved, so some other subsystem might mess with
them. The only suitable subsystem I found was oprofile though, and I
could neither get that to reproduce the hang here nor does oprofile show
up in your logs.

Anyway, both are bugs and should be fixed. Maybe we're even lucky and it
fixes your hang. *fingers crossed*

Björn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/