Re: [Intel-IOMMU 05/10] IOVA allocation and management routines

From: Keshavamurthy, Anil S
Date: Fri Jun 08 2007 - 14:29:22 EST


On Thu, Jun 07, 2007 at 04:34:17PM -0700, Andrew Morton wrote:
> On Wed, 06 Jun 2007 11:57:03 -0700
> anil.s.keshavamurthy@xxxxxxxxx wrote:
>
> > +
> > +#define PAGE_SHIFT_4K (12)
> > +#define PAGE_SIZE_4K (1UL << PAGE_SHIFT_4K)
> > +#define PAGE_MASK_4K (((u64)-1) << PAGE_SHIFT_4K)
> > +#define PAGE_ALIGN_4K(addr) (((addr) + PAGE_SIZE_4K - 1) & PAGE_MASK_4K)
>
> hm. We can't use the architecture's PAGE_SHIFT and friends here?
I will see how I can get rid of this.

-Anil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/