Re: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.

From: Robert P. J. Day
Date: Fri Jun 08 2007 - 12:21:32 EST

On Fri, 8 Jun 2007, Alan Cox wrote:

> > if a header file needs a definition/declaration that exists in another
> > header file, it should include that other header file. any other
> > approach is wrong.
> And if you try this in the real world for a project as large as the
> kernel you will die in a mass of unresolvable dependancy loops. The
> current behaviour is quite intentional

what utter nonsense. if i include tty.h, then i will be including
header files like workqueue.h and mutex.h and perhaps other rubbish i
have absolutely no interest in and don't want to waste my time

if i choose to invest an extra minute or two and be more selective and
include only those headers which represent content i actually *need*,
then i have every right to be a bit put out if my build suddenly

if you don't agree with that patch, fine. but suggesting that it's
going to result in "a mass of unresolvable dependancy loops" is sheer

Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at