Re: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.

From: Robert P. J. Day
Date: Fri Jun 08 2007 - 11:48:22 EST

On Fri, 8 Jun 2007, Alan Cox wrote:

> > i don't see how fixing the C file solves this issue. the header
> > file <linux/tty_driver.h> clearly refers to "struct ktermios", for
> > which it won't have a definition unless it includes
> > <asm/termbits.h>.
> Anyone using tty stuff will include <linux/tty.h> to get all the
> stuff needed an that includes asm/termios.h which includes
> asm/termbits.h

that may well be, but i don't think counting on the choice or order of
header file inclusions represents a really robust approach to software

if a header file needs a definition/declaration that exists in another
header file, it should include that other header file. any other
approach is wrong.

Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at