Re: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.

From: Robert P. J. Day
Date: Fri Jun 08 2007 - 11:44:10 EST

On Fri, 8 Jun 2007, Alan Cox wrote:

> > > >Risk - which compile combinations does it actually show up with and
> > > >is it not better to fix the C file in question not grow the
> > > >horribly tangled include deps further
> > >
> > > struct ktermios; /* that's it */
> >
> > um ... what does that mean? consider this snippet from
> > <linux/tty_driver.h>:
> Which compile combination shows the sequence you are reporting ?

sorry, i don't understand the question. i'm just running "make" on a
simple module i wrote, using the prototypical in-directory makefile to
build out-of-tree.

the first four lines of my module source file are:

#include <linux/module.h>
#include <linux/init.h>
#include <asm/termbits.h> /* Shouldn't be necessary */
#include <linux/tty_driver.h> /* For struct tty_driver */

if i omit the inclusion of the termbits.h header, i get the
aforementioned error. beyond that, i'm unclear on what you're asking.

Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at