[PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.

From: Robert P. J. Day
Date: Fri Jun 08 2007 - 09:31:39 EST

The header file <linux/tty_driver.h> should include <asm/termbits.h>
to pick up the definition of "struct ktermios"; otherwise, you run the
risk of seeing:

include/linux/tty_driver.h:142: warning: 'struct ktermios' \
declared inside parameter list
include/linux/tty_driver.h:142: warning: its scope is only \
this definition or declaration, which is probably not what you want

Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>


i'm *guessing* this is the solution to the above issue.

diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
index 85c95cd..b687174 100644
--- a/include/linux/tty_driver.h
+++ b/include/linux/tty_driver.h
@@ -123,6 +123,7 @@
#include <linux/fs.h>
#include <linux/list.h>
#include <linux/cdev.h>
+#include <asm/termbits.h>

struct tty_struct;

Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/