Re: [SERIAL] Don't optimise away baud rate changes when BOTHER isused (v2)

From: Alan Cox
Date: Fri Jun 08 2007 - 07:38:14 EST


On Fri, 08 Jun 2007 12:14:49 +0100
David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

> The uart_set_termios() function will bail out early without bothering to
> touch the hardware, if it decides that nothing "relevant" has changed.
> Unfortunately, its idea of "relevant" doesn't include c_[io]speed. So if
> the baud rate bits are BOTHER and you just change the speed, the change
> gets optimised away.
>
> This patch makes it ignore the old Bfoo bits in c_cflag and just check
> whether c_ispeed and c_ospeed have changed. Those integers are always
> set appropriately for us by set_termios().
>
> This version of the patch lacks the debugging printk which I
> accidentally left in the previous one.
>
> Signed-off-by: David Woodhouse <dwmw2@xxxxxxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/