Re: [patch 34/54] Fix roundup_pow_of_two(1)

From: Theodore Tso
Date: Fri Jun 08 2007 - 04:20:38 EST

On Fri, Jun 08, 2007 at 12:22:01AM -0700, Chris Wright wrote:
> -stable review patch. If anyone has any objections, please let us know.
> ---------------------
> From: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
> Fix roundup_pow_of_two(1)
> 1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does
> in case the argument is a variable but in case it's a constant it behaves
> wrong and returns 0. Probably nobody ever did it so this was never noticed.

If this doesn't fix a user-visiable bug, should we be including it in
the stable patch series? (Assuming that it doesn't, I wouldn't, but I
tend to be more conservative about what I would include in a stable
production release.)


- Ted
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at