Re: [PATCH 5/6] lockstat: human readability tweaks

From: Matthew Helsley
Date: Wed May 30 2007 - 15:39:30 EST


On Wed, 2007-05-30 at 14:49 +0200, Peter Zijlstra wrote:
> plain text document attachment (lockstat-output.patch)
> Present all this fancy new lock statistics information:
>
> *warning, _wide_ output ahead*
>
> (output edited for purpose of brevity)
>
> # cat /proc/lock_stat
> lock_stat version 0.1
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
> class name contentions waittime-min waittime-max waittime-total acquisitions holdtime-min holdtime-max holdtime-total
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------

<snip>

> 'contentions' and 'acquisitions' are the number of such events measured (since
> the last reset). The waittime- and holdtime- (min, max, total) numbers are
> presented in microseconds.

I think it would make sense to actually mention the time scale in the
output header someplace. Then a tool written to analyze this file will
have a way of determining the time scale without using error-prone
heuristics (like "kernel version foo uses microseconds while kernel foo
+ 100 uses nanoseconds").

<snip>

Cheers,
-Matt Helsley

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/