Re: [PATCH 02/22] 2.6.22-rc3 perfmon2 : generic kernel modifications

[Robin Holt]

On Wed, May 30, 2007 at 12:46:58AM +1000, Stephen Rothwell wrote:
> On Tue, 29 May 2007 06:48:16 -0700 Stephane Eranian <eranian@xxxxxxxxxxxxxxxxx> wrote:
> >
> > Only in linux-2.6.22/Documentation: perfmon2.txt
> 
> Did part of the patch go missing?
> 
> > diff --exclude=.git -urp --exclude-from=/tmp/excl315935 linux-2.6.22.base/Makefile linux-2.6.22/Makefile
> > --- linux-2.6.22.base/Makefile	2007-05-29 03:17:15.000000000 -0700
> > +++ linux-2.6.22/Makefile	2007-05-29 03:24:14.000000000 -0700
> > @@ -553,7 +553,7 @@ export mod_strip_cmd
> >
> >
> >  ifeq ($(KBUILD_EXTMOD),)
> > -core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/
> > +core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/ perfmon/
> 
> This should go near the end of the patch set so that the kernel will
> build at each step (if at all possible).
> 
> Seeing as what is missing below, naybe you should reorder the patch set
> so that the generic changes are at the end i.e. introduce all the new
> files and then wire them into the current ifrastructure.

That breaks git-bisect.  Just introducing new text, but not actually using
it makes it appear to somebody using git-bisect to identify the source of
a problem as though all the changes came in at the same time.  Bad idea.

Thanks,
Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/