Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache

[David Howells]

Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:

> All I do is to protect new calls to read() and write() with a call to
> check if the page cache needs invalidating.

What about mmap()?  What if someone gets a mapping on a section of file that
subsequently has a write rejected on it?  If you invalidate only on
read()/write(), what do you do about such a mapping?

> That won't stop any existing append writes from punching ugly holes into the
> file, but trying to recover from that sort of thing would be _really_
> painful!

Definitely.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/