Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

[Jeff Garzik]

Jeremy Fitzhardinge wrote:
> Jeff Garzik wrote:
> > > +        t3_intr_handler(adapter, qs->rspq.polling) (0,
> > > +                    (adapter->flags & USING_MSIX) ?
> > > +                    (void *)qs : (void *)adapter);
> > Remove needless casts to void*
> The two branches of ?: need to have the same type; without the casts
> they'd be "struct sge_qset" and "struct adapter".  Seems a bit cruddy to
> have two types passed to one function depending on the MSI state, but
> maybe that's OK.

Look at the function argument...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/