Re: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset

[Andrew Morton]

On Thu, 24 May 2007 09:56:01 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > > When a cpu is disabled, move_task_off_dead_cpu() is called for tasks 
> > > that have been running on that cpu.
> > 
> > So I still have these three patches in the pending queue but I was 
> > rather hoping that the scheduler, sched-domains and cpuset people 
> > could take a look at them, please.
> > 
> > They hit sched.c and cpuset.c mainly, and they might trash Ingo's CFS 
> > patch (I haven't checked).
> 
> The patch looks good to me. It applies cleanly ontop of CFS and it 
> builds and boots fine with and without CONFIG_CPU_HOTPLUG (although i 
> havent tried to explicitly stress the codepath in question). We are a 
> bit paranoid in this codepath but it's not performance-critical 
> normally.
> 
> Acked-by: Ingo Molnar <mingo@xxxxxxx>
> 

I applied this to -mm, thanks.

The other two patches don't apply well to the current pending patch queue
and nobody seems keen on doing a serious review (or any review, iirc), so I
ducked them.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/