Re: [PATCH 1/3] Preserve the dirty bit in init_page_buffers

[Nick Piggin]

Eric W. Biederman wrote:
> Nick Piggin <nickpiggin@xxxxxxxxxxxx> writes:

> > However we
> > could still set_page_dirty of a block device page without buffers
> > via an mmap.
>
>
> After the page is made dirty via mmap we have:
> sys_write -> ... -> block_prepare_write -> ... -> create_empty_buffers.

Yep, that's what I mean.


> I suspect that is a pretty rare case but it does indeed seem to exist
> as a problem.

I think so too. But either we have some misunderstanding of the
codepaths involved, or the author of the comments there didn't
consider this case, so...

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/