Re: [patch -mm 1/1] remove useless tolower in isofs

From: young dave
Date: Sun May 27 2007 - 23:11:23 EST


Hi,
And then there's the supercompact form.

while (len--) {
hash = partial_name_hash(tolower(*name++), hash);
}

But I do not like the last one at all. The first one is the best, because
it clearly separates the condition and iteration parts of the expression,
while STILL being only three lines long. Or two, if you omit the braces.
(But you shouldn't.)


IMO, I like the last one, but I prefer to keep the original author's
one, I only remove the unnecessary tolower function.
What do you think about this , Andrew?

Regards
dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/