Re: [patch] x86_64: fix sched_clock()

From: Ingo Molnar
Date: Fri May 25 2007 - 04:34:55 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> > > Hmm indeed. I actually had it correct at some point (i remember
> > > fixing 64bit compile errors in sched-clock ;-). I guess the
> > > Makefile hunk accidentially dropped out during some later merging
> > > and this didn't get noticed due to the weak attribute.
> >
> > well the tsc.h bit was needed too.
>
> It's not in defconfig at least. I just tried it.

what do you mean? The tsc.h bit is needed because
arch/i386/kernel/sched-clock.c (now built on x86_64 too with the patch i
sent) uses the tsc_disable global flag which is non-existent on x86_64.
So my tsc.h change adds that global flag, always-defined to 0.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/