Re: [patch] x86_64: fix sched_clock()

From: Ingo Molnar
Date: Fri May 25 2007 - 04:17:37 EST



* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> On Fri, 2007-05-25 at 09:54 +0200, Ingo Molnar wrote:
> > Subject: [patch] x86_64: fix sched_clock()
> > From: Ingo Molnar <mingo@xxxxxxx>
> >
> > sched_clock() is totally broken on x86_64, because it is not defined by
> > the architecture at all! It fell the victim to the opaqueness of
> > __attribute__((weak)) and to non-testing.
> >
> > the i386 version was supposed to be used. This patch fixes that. Booted
> > and tested on x86_64 and i386.
> >
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
>
> This does indeed solve my issue.

great! Btw., this is also accidental proof that CFS works well even with
a jiffies granularity sched_clock() ;-)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/