Re: [patch] x86_64: fix sched_clock()

[Andi Kleen]

On Fri, May 25, 2007 at 09:54:46AM +0200, Ingo Molnar wrote:
> Subject: [patch] x86_64: fix sched_clock()
> From: Ingo Molnar <mingo@xxxxxxx>
> 
> sched_clock() is totally broken on x86_64, because it is not defined by 
> the architecture at all! It fell the victim to the opaqueness of 
> __attribute__((weak)) and to non-testing.

More non retesting.

> 
> the i386 version was supposed to be used. This patch fixes that. Booted 
> and tested on x86_64 and i386.

Hmm indeed. I actually had it correct at some point (i remember
fixing 64bit compile errors in sched-clock ;-). I guess the Makefile hunk 
accidentially dropped out during some later merging and this didn't get 
noticed due to the weak attribute.

That also explains the issue reported by Peter earlier I guess.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/