Re: [patch] sched_clock(): cleanups
From: Andi Kleen
Date: Fri May 25 2007 - 03:32:17 EST
> if (!f)
> f = cpufreq_get(freq->cpu);
> if (!f)
> f = tsc_khz;
>
> ?
>
> Something's not quite right here :-)
What do you think is wrong? cpufreq_get can return 0.
Admittedly the second test could be inside a block of the first,
but then it would make the code more ugly and this code is not
performance critical.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/