Re: [2.6.22 patch] iop: combined watchdog timer driver for iop3xx and iop13xx

[Dan Williams]

On 5/6/07, Wim Van Sebroeck <wim@xxxxxxxxx> wrote:
> Hi Dan,
>
> > >Could you split this patch into 2 patches: one that deals with the moving
> > >of
> > >the architecture dependant code (and explaining why) and one with the new
> > >watchdog drivers? I will continue my review today.
> > >
> >
> > I am one of the maintainers of this architecture, (Lennert Buytenhek
> > is the other).  I will go ahead and split this up so you can sign-off
> > on the watchdog specific bits.  The intent is to move all hardware
> > definitions under #include <asm/hardware.h>.  You are right this
> > should have been a separate patch.
>
> I reviewed the rest of the code. Looks OK to me. One small remark though:
> Can we change the ifdef's in the code as described in section 2 point 2 of
> the Documentation/SubmittingPatches document?
Ok, I can add this cleanup.

Barring any objections I'll go ahead and submit the revised patch with
an "Acked-by: Wim Van Sebroeck <wim at iguana dot be>" to Russell's
ARM patch tracker.

> Thanks,
> Wim.

Dan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/