Re: [PATCH -mm] PM: Separate hibernation code from suspend code

From: Andrew Morton
Date: Sat May 05 2007 - 02:33:39 EST


On Fri, 4 May 2007 11:32:31 +0200 "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> Separate the hibernation (aka suspend to disk code) from the other suspend code.
> In particular:
> * Remove the definitions related to hibernation from include/linux/pm.h
> * Introduce struct hibernation_ops and a new hibernate() function to hibernate
> the system, defined in include/linux/suspend.h
> * Separate suspend code in kernel/power/main.c from hibernation-related code
> in kernel/power/disk.c and kernel/power/user.c (with the help of
> hibernation_ops)
> * Switch ACPI (the only user of pm_ops.pm_disk_mode) to hibernation_ops

This causes the long-suffering Vaio to fail to power off during suspend
to disk. It says "Please power me down manually".

<debugs a bit>

machine_ops.halt(); points at native_machine_halt(), which is a no-op.

However `halt -p' still works OK. How come it is not similarly affected?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/