Re: [PATCH] AF_RXRPC: Sort out MTU handling

From: David Miller
Date: Fri May 04 2007 - 15:43:01 EST


From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 04 May 2007 15:56:47 +0100

> Sort out the MTU determination and handling in AF_RXRPC:
>
> (1) If it's present, parse the additional information supplied by the peer at
> the end of the ACK packet (struct ackinfo) to determine the MTU sizes
> that peer is willing to support.
>
> (2) Initialise the MTU size to that peer from the kernel's routing records.
>
> (3) Send ACKs rather than ACKALLs as the former carry the additional info,
> and the latter do not.
>
> (4) Declare the interface MTU size in outgoing ACKs as a maximum amount of
> data that can be stuffed into an RxRPC packet without it having to be
> fragmented to come in this computer's NIC.
>
> (5) If sendmsg() is given MSG_MORE then it should allocate an skb of the
> maximum size rather than one just big enough for the data it's got left
> to process on the theory that there is more data to come that it can
> append to that packet.
>
> This means, for example, that if AFS does a large StoreData op, all the
> packets barring the last will be filled to the maximum unfragmented size.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied, thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/