Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters
From: Eric Dumazet
Date: Fri May 04 2007 - 11:35:30 EST
On Fri, 04 May 2007 15:30:57 +0100
James Pearson <james-p@xxxxxxxxxxxxxxxxxx> wrote:
> /proc/PID/environ currently truncates at 4096 characters, patch based on
> the /proc/PID/mem code.
>
> Signed-off-by: James Pearson <james-p@xxxxxxxxxxxxxxxxxx>
>
What about latency when reading one *big* environ ?
Dont we need some cond_resched() test in the loop ?
> +
> +static struct file_operations proc_environ_operations = {
> + .read = environ_read,
> +};
> +
Please use the const qualifier here :
static const struct file_operations ...
Thank you
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/