Re: [RFC PATCH 1/3] Replace paravirt_probe with "platform type" boot header field

From: Eric W. Biederman
Date: Fri May 04 2007 - 11:11:40 EST


Rusty Russell <rusty@xxxxxxxxxxxxxxx> writes:

> On Fri, 2007-05-04 at 08:01 -0600, Eric W. Biederman wrote:
>> We should place that initial branch right after startup_32,
>> we don't need the startup_paravirt at all now.
>>
>> ENTRY(startup_32)
>> #ifdef CONFIG_LGUEST_GUEST
>> cmpl $1, 0x23c(%esi)
>> je lguest_init
>> #endif
>
> Hi Eric!
>
> Makes sense to me, but I wasn't sure... do we need to check for old
> bootloader versions and such?

Thinking about this a little more. It probably makes sense to move the
test for lguest down to just before we initialize the page tables. That
way we can share common bss clearing code and parameter parsing setup
code.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/