Re: [PATCH v2] lib/hexdump

[Hugh Dickins]

On Thu, 3 May 2007, Randy Dunlap wrote:
> 
> Example output using %DUMP_PREFIX_OFFSET:
> 0009ab42: 40414243 44454647 48494a4b 4c4d4e4f-@ABCDEFG HIJKLMNO
                                               ^        ^
> Example output using %DUMP_PREFIX_ADDRESS:
> ffffffff88089af0: 70717273 74757677 78797a7b 7c7d7e7f-pqrstuvw xyz{|}~.
                                                       ^        ^
I see that hyphen as joining together two unlike fields rather than
separating them: maybe change it to a couple of spaces?  And the space
halfway through the string is more interfering than helpful (when that
field is useful, it's a string: which shouldn't have a spurious space
inserted).  Otherwise looks nice to me.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/