Re: [PATCH] synclink_gt use dynamic tty device registration

From: Andrew Morton
Date: Thu May 03 2007 - 03:06:28 EST


On Wed, 02 May 2007 11:17:33 -0500 Paul Fulghum <paulkf@xxxxxxxxxxxxx> wrote:

> Change synclink_gt driver to use dynamic tty device registration.
>
> ...
>
> + for (i=0; i < port_count; ++i)
> + tty_register_device(serial_driver, port_array[i]->line, &(port_array[i]->pdev->dev));
> ...
> + for (info=slgt_device_list ; info != NULL ; info=info->next_device)
> + tty_unregister_device(serial_driver, info->line);
> ...
> + if ((rc = pci_register_driver(&pci_driver)) < 0) {

hm, not a big fan of kernel coding style, I see.

What's going to happen here if tty_register_device() fails?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/