Re: [PATCH] i386: fix suspend/resume with dynamically allocated irq stacks

[Bill Irwin]

On Wed, May 02, 2007 at 06:56:09PM -0700, Jeremy Fitzhardinge wrote:
> +static void __cpuinit __free_irqstack(int cpu, void *stk)
> +{
> +	int i;
> +
> +	if (!cpu)
> +		return;
> +
> +	unmap_vm_area(per_cpu(irqstack_area, cpu));
> +
> +	for (i = 0; i < THREAD_SIZE/PAGE_SIZE; ++i)
> +		__free_page(per_cpu(irqstack_pages, cpu)[i]);
> +}

This will leak the vm_struct and also leave it in the vmlist.
work_free_thread_info() needs to be redone too. It should be

	remove_vm_area( /* unmap and remove the vm_struct from vmlist */ );
	kfree( /* free the vm_struct */ );
	for (i = 0; i < THREAD_SIZE/PAGE_SIZE; ++i)
		__free_page( /* dredge up the appropriate page to free */ );


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/