Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

From: Andi Kleen
Date: Wed May 02 2007 - 05:28:28 EST



> Most comments states Cyrix CPUs when they are using the macros. Is anything
> with Cyrix 64 bit relevant? Maybe "include/asm-x86_64/processor.h" is a
> simple copy of "include/asm-i386/processor.h" and nobody delete the unused
> macros?

It was originally deleted but later readded when the MTRR code was merged together.
That's because of i386/kernel/cpu/mtrr/state.c which is compiled on x86-64 too.
If you can move that code into cyrix.c it can be removed. Might be a good opportunity
to clean this up.

> Please keep me informed and I will resend the patch.

I would need an patch against the current ff tree that doesn't break x86-64.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/