Re: [patch 01/10] compiler: define __attribute_unused__

From: Rusty Russell
Date: Wed May 02 2007 - 01:41:51 EST


On Tue, 2007-05-01 at 21:28 -0700, David Rientjes wrote:
> For all supported versions of gcc (major version 3 and above), functions
> and variables may be declared with __attribute__((unused)) to suppress
> warnings if they are declared but unused.

Adding this macro doesn't give us anything that simply saying
"__attribute__((unused))" doesn't give. But it does add a layer of
kernel-specific indirection.

If we're going to get kernel-specific, I'd prefer to see:

__needed: suppress warning and don't discard,
__unneeded: suppress warning and might discard.

For me this fits better with how I think.

Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/