Re: [PATCH] fix dynticks for voyager

From: James Bottomley
Date: Tue May 01 2007 - 20:48:03 EST


On Tue, 2007-05-01 at 17:26 -0700, Jeremy Fitzhardinge wrote:
> Matt Mackall wrote:
> > On Mon, Apr 30, 2007 at 11:38:51AM -0500, James Bottomley wrote:
> >
> >> As usual voyager tripped over an explicit boot CPU is zero assumption in
> >> the dynticks code. This is the fix I have queued in the voyager tree.
> >>
> >
> > Can we flush out all these assumptions by adding a constant offset
> > somewhere? Or reversing the ordering?

It might be useful to voyager, but unless the offset were random, people
would simply hardwire it.

> My understanding is that the boot CPU is random depending on who wins
> the "I get to boot" bunfight.

Not quite. On apic systems, the boot CPU can be an arbitrary physical
id but is conventionally logical id 0. On voyager, the CPU id actually
maps to a fixed location, so there's no sense in having a logical id.
The booting CPU on voyager is simply the lowest numbered CPU that comes
up through the SUS boot.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/