Re: [patch 29/33] SONIC interrupt handling

[Christoph Hellwig]

On Tue, May 01, 2007 at 10:33:03PM +0200, Geert Uytterhoeven wrote:
> +static int jazzsonic_open(struct net_device* dev) {
> +	if (request_irq(dev->irq, &sonic_interrupt, IRQF_DISABLED, "sonic", dev)) {
> +		printk(KERN_ERR "\n%s: unable to get IRQ %d.\n", dev->name, dev->irq);
> +		return -EAGAIN;
> +	}
> +	return sonic_open(dev);
> +}

Opening brace for a function on a line of it's own please.

Also starting a printk with '\n' seems rather odd.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/