Re: [1/3] dynamically allocate IRQ stacks

[Heiko Carstens]

> +static void * __init __alloc_irqstack(int cpu)
> +{
> +	if (!cpu)
> +		return __alloc_bootmem(THREAD_SIZE, THREAD_SIZE,
> +						__pa(MAX_DMA_ADDRESS));
> +
> +	return (void *)__get_free_pages(GFP_KERNEL,
> +					ilog2(THREAD_SIZE/PAGE_SIZE));
> +}

I think you should test for slab_is_available() instead of checking
if the cpu number is 0.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/