Re: condingstyle, was Re: utrace comments

From: David Howells
Date: Tue May 01 2007 - 12:13:29 EST


John Anthony Kazos Jr. <jakj@xxxxxxxxxxx> wrote:

> if (veryverylengthycondition1
> && smallcond2
> && (conditionnumber3a
> || condition3b)) {
> ...
> }
>
> Clear, crisp, and 80-wide. I also like how the logical operator on the
> following line is indented slightly into the condition of the previous
> line.

The brain works better when associated things are lined up, so:

if (veryverylengthycondition1 &&
smallcond2 &&
(conditionnumber3a ||
condition3b)) {

is better as it gives a visual clue to association.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/