Re: condingstyle, was Re: utrace comments

From: John Anthony Kazos Jr.
Date: Tue May 01 2007 - 11:06:50 EST


> > if (veryverylengthycondition1 &&
> > smallcond2 &&
> > (conditionnumber3a ||
> > condition3b)) {
> > ...
> > }
>
> It's horrid. I'd much rather see
>
> if (veryverylengthycondition1 &&
> smallcond2 &&
> (conditionnumber3a || condition3b)) {
> ...
> }

if (veryverylengthycondition1
&& smallcond2
&& (conditionnumber3a
|| condition3b)) {
...
}

Clear, crisp, and 80-wide. I also like how the logical operator on the
following line is indented slightly into the condition of the previous
line. I think this is much more sensical and sensible than using spaces to
line them up with the parentheses. Makes clear for each operator the
condition to which it applies.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/