Re: [PATCH] worker_thread: don't play with SIGCHLD

[Eric W. Biederman]

Oleg Nesterov <oleg@xxxxxxxxxx> writes:

> depends on Eric's
>
> 	kthread-dont-depend-on-work-queues-take-2.patch
>
> worker_thread() inherits ignored SIGCHLD from its parent, kthreadd.
> We can remove unneeded do_sigaction().

Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Looks good.

We could delete all of:

> 	set_user_nice(current, -5);
> 
> 	/* Block and flush all signals */
> 	sigfillset(&blocked);
> 	sigprocmask(SIG_BLOCK, &blocked, NULL);
> 	flush_signals(current);
> 
> 	/*
> 	 * We inherited MPOL_INTERLEAVE from the booting kernel.
> 	 * Set MPOL_DEFAULT to insure node local allocations.
> 	 */
> 	numa_default_policy();
> 
> 	/* SIG_IGN makes children autoreap: see do_notify_parent(). */
> 	sa.sa.sa_handler = SIG_IGN;
> 	sa.sa.sa_flags = 0;
> 	siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
> 	do_sigaction(SIGCHLD, &sa, (struct k_sigaction *)0);

If we wanted to, as that all comes by default from kthreadd.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/