[PATCH] wait_for_helper: remove unneeded do_sigaction()

From: Oleg Nesterov
Date: Fri Apr 13 2007 - 03:28:49 EST


allow_signal(SIGCHLD) does all necessary job, no need to call do_sigaction()
prior to.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- 2.6.21-rc5/kernel/kmod.c~WH 2007-04-05 12:18:28.000000000 +0400
+++ 2.6.21-rc5/kernel/kmod.c 2007-04-13 11:14:00.000000000 +0400
@@ -181,14 +181,9 @@ static int wait_for_helper(void *data)
{
struct subprocess_info *sub_info = data;
pid_t pid;
- struct k_sigaction sa;

/* Install a handler: if SIGCLD isn't handled sys_wait4 won't
* populate the status, but will return -ECHILD. */
- sa.sa.sa_handler = SIG_IGN;
- sa.sa.sa_flags = 0;
- siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
- do_sigaction(SIGCHLD, &sa, NULL);
allow_signal(SIGCHLD);

pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/