Re: [patch] convert aio event reap to use atomic-op instead of spin_lock

[Ken Chen]

On 4/11/07, Ken Chen <kenchen@xxxxxxxxxx> wrote:
> On 4/11/07, Zach Brown <zach.brown@xxxxxxxxxx> wrote:
> > First, I'll NAK this and all AIO patches until the patch description
> > says that it's been run through the regression tests that we've started
> > collecting in autotest.  They're trivial to run, never fear:
>
> OK.  I will run those regression tests.

Unfortunately, the aio_dio_bugs test in autotest has bug in it :-(
We need stress test the "test code".

on stock 2.6.21-rc6 kernel:

[rock-me-baby]$ cd autotest/tests/aio_dio_bugs/src
[rock-me-baby]$ make
[rock-me-baby]$ ./aio-free-ring-with-bogus-nr-pages
aio-free-ring-with-bogus-nr-pages: Error: io_setup returned -22,
expected -ENOMEM

hmm???  The problem is that the test code forgot to initialized ctx
variable and in the kernel, sys_io_setup returns EINVAL if user
address contain none-zero value.

I will submit the following patch to autotest to correct the test code.

--- aio-free-ring-with-bogus-nr-pages.c.orig	2007-04-11 23:57:45 -0700
+++ aio-free-ring-with-bogus-nr-pages.c	2007-04-11 23:57:59 -0700
@@ -39,7 +39,7 @@
int main(int __attribute__((unused)) argc, char **argv)
{
	long res;
-	io_context_t ctx;
+	io_context_t ctx = 0;
	void* map;

	while (1) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/