Re: [PATCH 6/13] maps#2: Move the page walker code to lib/

[Nick Piggin]

Matt Mackall wrote:
> On Wed, Apr 11, 2007 at 04:35:44PM +1000, Nick Piggin wrote:
>
> > Matt Mackall wrote:
> >
> > > Move the page walker code to lib/
> > >
> > > This lets it get shared outside of proc/ and linked in only when
> > > needed.
> >
> > Still should go into mm/
> >
> > If it had, you might have also noticed your pagetable walking code
> > is completely different from how everyone else does it, and fixed
> > that too.
>
>
> I actually did notice that, when I compared it to jsgf's page walking
> code for Xen.

Can you fix it then, since you are doing the big reorganisation?

>  
>
> > BTW. Is it the case that unused and unexported symbols don't get
> > pruned by the linker except inside lib/?
>
>
> Yes, that's been my point all along. It also currently only happens at
> the granularity of an object file, not a symbol, FYI.

You have the config symbols, don't you? Please use them in the
makefile to prevent compiling and linking.

My point all along is that it belongs in mm/. If you don't want to
do it then I can't make you, but I'll submit a patch to use the
correct page table walking conventions and move it to mm/.

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/