Re: [PATCH] kthread: Don't depend on work queues (take 2)

From: Eric W. Biederman
Date: Wed Apr 11 2007 - 16:04:36 EST


Oleg Nesterov <oleg@xxxxxxxxxx> writes:

> Ah yes, we still need to export kthreadd_task... I just worried about subtle
> dependency this patch adds... This "kthreadd_task = find_task_by_pid" assumes
> that init/main.c:init() takes lock_kernel() before the first kthread_create().

There is a small element of that. Mostly it assumes we are running in the idle
thread until we call schedule. Anyway the assumption and the code is out
there in the open in the main code path so it is easy to find, and the code works
today.

At this point I am queuing up patches that kill daemonize. I will be
happy to revisit this part once daemonize is gone and the only interesting
file is kthread.c

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/