Re: [PATCH 20/30] Use menuconfig objects - ARCNET

[Esben Nielsen]

On Tue, 10 Apr 2007, Jan Engelhardt wrote:

> (Wow, not a single MODULE_AUTHOR line in drivers/net/arcnet/ ...)


ArcNet is old. Almost nobody is using it anymore. I used it at my former 
job, since we used it as control network. A lot of companies still does 
quitely, but not in combination with Linux.

> Use menuconfigs instead of menus, so the whole menu can be disabled at
> once instead of going through all options.
>
> Signed-off-by: Jan Engelhardt <jengelh@xxxxxx>
>
> Index: linux-2.6.21-rc5/drivers/net/arcnet/Kconfig
> ===================================================================
> --- linux-2.6.21-rc5.orig/drivers/net/arcnet/Kconfig
> +++ linux-2.6.21-rc5/drivers/net/arcnet/Kconfig
> @@ -2,10 +2,8 @@
> # Arcnet configuration
> #
>
> -menu "ARCnet devices"
> +menuconfig ARCNET
> 	depends on NETDEVICES && (ISA || PCI)

Why does it depend on ISA || PCI ? People tend to forget the PCMCIA 
driver. And in principle you could enable the ArcNet framework without 
using any of the drivers in the kernel tree.


Esben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/