Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

From: Eric W. Biederman
Date: Tue Apr 10 2007 - 23:31:50 EST


"Serge E. Hallyn" <serge@xxxxxxxxxx> writes:

> Quoting Oleg Nesterov (oleg@xxxxxxxxxx):
>> 1. rename reparent_to_init() to reparent_kthread() and export it
>>
>> 2. use init_pid_ns.child_reaper instead of child_reaper(current)
>
> Each of these patches looks good to me, but this part in particular
> is a must-have bugfix.

Removing daemonize is a must have bug fix. This falls short of that so
it is a good fix, but it doesn't solve the core problem that kernel daemons
are being assigned pids inside of child pid namespaces.

It doesn't solve the problem that some kernel daemons are using signals
to communicate with user space.

It doesn't solve the problem that we have to do a lot of massaging and
maintenance to get kernel threads from grabbing references to namespaces
and other kernel pieces they should not be grabbing.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/